feat: Upgrade to binaryen v0.37 - #2401
Open
spotandjake wants to merge 2 commits into
Open
Conversation
spotandjake
requested review from
alex-snezhko,
marcusroberts,
ospencer,
peblair and
phated
as code owners
September 3, 2026 17:05
Kara-Zor-El
requested changes
Sep 4, 2026
This pr upgrades our binaryen.ml version from `0.35` to `0.37`. In binaryen.ml `0.36` we upgraded jsoo from `6.3` to `6.4` which forces us to update our cmdliner version to `2.0`. This change broke the `ppx_deriving_cmdliner` module as it hasn't been updated in 4 years. As such I dropped the library and instead of using the macros to generate our cmdliner terms we just write them manually, it's slightly more verbose but not to bad. This pr also updates our optimization passes to follow binaryenes default ordering until we decide to diverge.
spotandjake
force-pushed
the
spotandjake/binaryen-37
branch
from
September 4, 2026 20:02
a375715 to
7962341
Compare
Kara-Zor-El
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr upgrades our binaryen.ml version from
0.35to0.37.In binaryen.ml
0.36we upgraded jsoo from6.3to6.4which forces us to update our cmdliner version to2.0. This change broke theppx_deriving_cmdlinermodule as it hasn't been updated in 4 years.As such I dropped the library and instead of using the macros to generate our cmdliner terms we just write them manually, it's slightly more verbose but not to bad.
This pr also updates our optimization passes to follow binaryenes default ordering until we decide to diverge.