Skip to content
This repository was archived by the owner on Sep 21, 2020. It is now read-only.

GPII-4273 - #610

Open
klown wants to merge 16 commits into
gpii-ops:masterfrom
klown:GPII-4273
Open

klown wants to merge 16 commits into
gpii-ops:masterfrom
klown:GPII-4273

Conversation

@klown

@klown klown commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

Preliminary PR for testing the changes to gpii-universal for GPII-4273 in GCP.

https://issues.gpii.net/browse/GPII-4273

@klown

klown commented Apr 22, 2020

Copy link
Copy Markdown
Contributor Author

Merged changes from @stepanstipl 's Fix egress TLS traffic PR #613. The production tests work now.

Comment thread shared/versions.yml
repository: herrclown/vagrant-universal
tag: latest
generated:
repository: gcr.io/gpii-common-prd/gpii__universal

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep using the gpii/universal official repository instead. Is this possible @klown ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amatas
We won't be using this version of versions.yml because my changes to gpii-universal have not been merged into master yet; and versions.yml is using my docker image for the flowmanager, preferences, dataloader, flushtokens, and productiontests components. When the changes have been merged into master, I will update versions.yml to reference the gpii/universal repository with the correct tag.

This PR is not ready to merge into gpii-infra's master branch. It's just a way of testing the changes in my dev cluster, in concert with @stepanstipl's changes to istio.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mark this PR as "work-in-progress", but I don't have the authority to add labels.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it, thanks @klown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants