Repository navigation
feat(generators): bass low-fifth reach — rfoPattern 'low5' (v0.1.15) - #9
ChrisBeWithYou wants to merge 1 commit into
Conversation
bassRootGrip only reached UP (fifth s+1, octave s+2); the fifth BELOW the root - the reach the low string exists for, and the whole point of a 5-string's B - had no primitive (deferred from the string-count audit). bassRootGrip gains lowFifth: the P5 below the root on the string below, computed by pitch with an exact-midi check. Guards (bass-pedagogy spec 2026-07-12): root.s>=1 (a string exists below) AND root.f>=2 (at f0/f1 the pc-math octave-push wraps the note UP a 4th - the opposite of intent); null when unavailable. root_fifth_octave gains the opt-in rfoPattern='low5' variant: R-low5-5-8 (root on the downbeat, traverses both fifths + the octave); an unreachable low fifth degrades to the upper 5th so the pattern stays playable everywhere. The default R-5-8-5 box is deliberately untouched (the canonical pre-scales lesson) - guarded byte-identical by smoke. Scope per spec: root_fifth_octave ONLY (octave_groove stays pure R-8 per the soul-motown ruling; the right_hand_technique modes are pitch-invisible by design). No root-selection bias - nearest-to-prev stands. The Root-5th-Octave rung gains a final vary step teaching the reach (rfoPattern coded in base so it never leaks across the rung's own vary steps). Smoke: smoke-strings row (15) - low5 geometry (R, root-7 on the string below, 5th, octave), default-parity (field absent === 'r5o', byte-identical), 4-string null-degrade to the upper 5th. Full run 16/19 (the 3 pre-existing base reds). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MS2YFb6UUSwJVV6CmEa25i
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Landed on |
1 participant
What
bassRootGriponly reached up (fifth on s+1, octave on s+2). The fifth below the root — the reach the low string exists for, and the whole point of a 5-string's B — had no primitive (the item deferred from the string-count audit).bassRootGripgainslowFifth: P5 below the root on the string below, computed by pitch with an exact-midi check.root_fifth_octavegains the opt-inrfoPattern='low5'variant: R–low5–5–8; unreachable low fifth degrades to the upper 5th.Pedagogy spec (bass-pedagogy, 2026-07-12 — implemented verbatim)
root.s>=1androot.f>=2(at f0/f1 the pc-math octave-push wraps the note up a 4th — the opposite of intent); null → degrade.root_fifth_octaveonly (octave_groove stays pure R-8 per the soul-motown ruling; right_hand_technique modes are pitch-invisible by design).Verification
C2·F1·G2·C3), default byte-parity, 4-string null-degrade to the upper 5th.🤖 Generated with Claude Code
https://claude.ai/code/session_01MS2YFb6UUSwJVV6CmEa25i