[byrongamatos]

What

Step 9 — second keystone of the entangled-core split. Lifts the 9 reassigned streaming-path scalars out of main.js's IIFE scope into an ST container in state.js:

streaming, streamTracks, streamSampleRate, streamTotalSamples, jsWriteFrontier, pumpStop, lastWorkletPos, posWaiter, streamSeekToken

Same read-only-binding rationale as S/SH. These are read across the transport layer, onWorkletMessage, and onSongReady (the bounded-window pump, seek reposition, and playhead all key off them), so they must be shared — not private to the future streaming.js. Pure state-lift, no behavior change. Unblocks extracting src/streaming.js next.

Rewrite safety

Context-audited (the big-file lesson from step 4b):

• The 8 compound identifiers rewrote blind — every occurrence is code (object values / string-concatenated variables), verified.
• streaming collides with the English word in 10 places (comments + console.warn('…not streaming')), so it was rewritten only in its 6 code contexts ((streaming, !streaming, streaming = ). The 10 English mentions are left untouched.
• Post-rewrite: 0 double-prefixes, 0 bare refs, parse clean.

Tests

Full suite green (npm test, 41 pass); tests/test_manifest.py green. Codex preflight: 0 issues.

On-device smoke pending — this is the streaming playback path (the pump feeding the worklet). Verify multi-stem playback, seek/scrub, and pause/resume don't stall or desync.

Summary by CodeRabbit

• Bug Fixes

  • Improved streaming playback reliability, including seeking, buffering, and track switching.
  • Fixed issues where mixed sample-rate audio could cause incorrect playback; incompatible streams now fall back safely.
  • Better handling of stream cancellation and teardown to prevent stuck playback states.

• Refactor

  • Consolidated streaming playback state into a shared central state, making transport and pump behavior more consistent.

[coderabbitai]

📝 Walkthrough

Walkthrough

Streaming playback state in src/main.js is refactored to use a new exported ST container defined in src/state.js, replacing file-local variables for streaming mode, track streams, sample-rate/length accounting, pump frontiers, worklet position, seek tokens, and pos waiters across transport, pump, and setup logic.

Changes

Streaming state consolidation

Layer / File(s)	Summary
ST state container definition src/state.js, src/main.js (import)	Adds exported ST object holding streaming flags, track descriptors, sample-rate/length, pump/frontier fields, waiter, and seek token; imports it into main.js.
Transport and worklet position handling src/main.js	Worklet 'pos' handling, buffering checks, and transportPlay/transportSeek streaming conditions now use ST.lastWorkletPos, ST.streaming, ST.streamSampleRate, ST.jsWriteFrontier, ST.posWaiter.
Streaming pump loop implementation src/main.js	appendRound, waitPos, runPump use ST.streamTotalSamples, ST.lastWorkletPos, ST.jsWriteFrontier, ST.streamTracks, ST.pumpStop.
Stream reseek and reader handling src/main.js	openTrackStreams and repositionStream use ST.streamTracks, ST.streamSeekToken, and update ST.jsWriteFrontier/ST.lastWorkletPos on seek.
Streaming setup and initialization src/main.js	setupStreaming sample-rate pinning, full-mix track inclusion, track installation, and worklet-open logic use ST.streamSampleRate/ST.streamTracks; resetStreamState resets ST.* fields and resolves pending ST.posWaiter.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Worklet
  participant main_js as main.js
  participant ST
  participant Pump as runPump/appendRound

  Worklet->>main_js: postMessage('pos', position)
  main_js->>ST: update ST.lastWorkletPos
  main_js->>ST: resolve ST.posWaiter
  ST-->>Pump: waitPos() resolves
  Pump->>ST: read ST.jsWriteFrontier, ST.streamTracks
  Pump->>Worklet: postMessage('append', base=ST.jsWriteFrontier)
  Pump->>ST: update ST.jsWriteFrontier

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: moving streaming-path state into the shared ST container in state.js.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/es-module-lift-stream-state

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Refactors the stems plugin’s streaming-playback path by moving the streaming-path mutable scalars out of main.js’s IIFE scope into a shared exported ST state container in state.js, aligning with the existing S / SH shared-container pattern and enabling the upcoming extraction of streaming logic into its own module.

Changes:

• Introduces ST in src/state.js to hold streaming-path state that must be shared across transport, onWorkletMessage, and streaming setup/teardown.
• Rewrites streaming-path reads/writes in src/main.js to use ST.* instead of IIFE-local variables.
• Removes the now-redundant local streaming-path scalar declarations from main.js (pure state lift; behavior intended to remain unchanged).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/state.js	Adds the exported ST container to hold streaming-path mutable state alongside existing shared state containers.
src/main.js	Switches streaming-path logic to reference ST.* and deletes the previously IIFE-local streaming scalar variables.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main.js`:
- Around line 1271-1305: The pump loop in runPump(), along with its
appendRound() and waitPos() continuations, can keep running after
repositionStream() starts a new seek and clears ST.pumpStop, allowing stale
iterations to post outdated append data or leave an old ST.posWaiter hanging.
Capture the current ST.streamSeekToken when a pump cycle starts, and re-check
that token after each await and before any postMessage/resolve work so
superseded iterations exit early. Apply the same token guard to the
seek/reposition flow that resets pump state so only the latest stream seek can
continue.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a86c3b02-df40-4bd8-b03e-c547f34d161b

📥 Commits

Reviewing files that changed from the base of the PR and between 1c9730f and 31056d5.

📒 Files selected for processing (2)

• src/main.js
• src/state.js