Skip erase secrets by default - #232
Merged
Merged
Conversation
Member
|
Sounds good, but shouldn't this be the default then? |
Author
|
Becoming default is not compatible with previous versions. I'm fine with it and can update the PR. |
zhangcar-ms
force-pushed
the
no-erase
branch
2 times, most recently
from
August 10, 2026 05:33
681f45e to
94dc599
Compare
zhangcar-ms
changed the title
Author
|
Updated the PR, the default behavor is now to skip erasing secrets, but users can add the option '--erase' to have the same behavors of the previous version. |
dominikschulz
requested changes
Aug 10, 2026
| if err != nil { | ||
| return fmt.Errorf("error: %w while parsing git-credential", err) | ||
| } | ||
| if cmd.Bool("erase") { |
Member
There was a problem hiding this comment.
The diff and nesting would be much nicer to read if you'd simply check for if !cmd.Bool("erase") { return nil }.
dominikschulz
approved these changes
Aug 12, 2026
Skip erasing secrets when git asks 'erase' function from the helper. User should manually run 'gopass rm ...' command to erase secrets.
zhangcar-ms
force-pushed
the
no-erase
branch
from
September 10, 2026 05:23
acf52ea to
f6dbde1
Compare
dominikschulz
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add '--no-erase' option to skip erasing secrets when git ask 'erase' function from the helper.
User should manually run 'gopass rm ...' command to remove secrets.