fix(spanner): system test against regular sessions#8872
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the error assertions in the Spanner system tests by removing conditional checks on KOKORO_JOB_NAME and directly asserting that the error code is grpc.status.INVALID_ARGUMENT. I have no feedback to provide as there are no review comments to evaluate.
alkatrivedi
force-pushed
the
fix-system-test
branch
7 times, most recently
from
1dec43a to
a673c48
Compare
alkatrivedi
force-pushed
the
fix-system-test
branch
from
a673c48 to
764a3cb
Compare
danieljbruce
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix system test against regular sessions which are failing due to running them in Cloud Builds.