perf(Spanner): Eliminate extend overhead#8865
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the external extend dependency with native Object.assign and explicit property assignments across various source and test files in the Spanner client library. The reviewer feedback is highly constructive, suggesting the complete elimination of the remaining extend deep copies by using shallow copies with Object.assign where safe. Additionally, the reviewer points out several redundant type assertions (such as casting gaxOpts and reqOpts) that can be removed to simplify and clean up the conditional property assignments.
22cce10 to
6fb792b
Compare
6fb792b to
2900512
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request removes the third-party extend dependency across the Spanner codebase, replacing its usage with native Object.assign() and logical nullish assignment (??=) operators. This refactoring affects both source and test files, simplifying object merging and copying. There are no review comments, and I have no feedback to provide.
Removing unnecessary overhead from the extend dependency where simple shallow merges are sufficient to reduce CPU ticks and improvement in the performance of node client