Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions null.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,21 @@ func (nu *NullUUID) Scan(value interface{}) error {
return nil
}

// Treat empty database values as NULL. UUID.Scan("") leaves a Nil UUID
// and returns nil, which would otherwise mark Valid=true (issue #109).
switch v := value.(type) {
case string:
if v == "" {
nu.UUID, nu.Valid = Nil, false
return nil
}
case []byte:
if len(v) == 0 {
nu.UUID, nu.Valid = Nil, false
return nil
}
}

err := nu.UUID.Scan(value)
if err != nil {
nu.Valid = false
Expand Down
34 changes: 34 additions & 0 deletions null_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,3 +212,37 @@ func TestNullUUIDUnmarshalJSON(t *testing.T) {
t.Errorf("expected nil when unmarshalling null, got %s", err)
}
}

func TestNullUUIDScanEmpty(t *testing.T) {
var nu NullUUID
// Start from a valid value to ensure empty clears Valid.
if err := nu.Scan("12345678-abcd-1234-abcd-0123456789ab"); err != nil {
t.Fatalf("setup scan: %v", err)
}
if !nu.Valid {
t.Fatal("expected Valid after setup")
}

if err := nu.Scan(""); err != nil {
t.Fatalf("empty string scan: %v", err)
}
if nu.Valid {
t.Error("expected Valid=false after scanning empty string")
}
if nu.UUID != Nil {
t.Errorf("expected Nil UUID after empty string, got %v", nu.UUID)
}

if err := nu.Scan("12345678-abcd-1234-abcd-0123456789ab"); err != nil {
t.Fatalf("re-setup scan: %v", err)
}
if err := nu.Scan([]byte{}); err != nil {
t.Fatalf("empty []byte scan: %v", err)
}
if nu.Valid {
t.Error("expected Valid=false after scanning empty []byte")
}
if nu.UUID != Nil {
t.Errorf("expected Nil UUID after empty []byte, got %v", nu.UUID)
}
}