Skip to content

[BUG] set_cover Python: fix UB in the all_subsets property #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jg-codes wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −12
Open

[BUG] set_cover Python: fix UB in the all_subsets property #5121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions ortools/set_cover/python/set_cover.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ using ::py::make_iterator;
std::vector<SubsetIndex> VectorIntToVectorSubsetIndex(
absl::Span<const BaseInt> ints) {
std::vector<SubsetIndex> subs;
std::transform(ints.begin(), ints.end(), subs.begin(),
subs.reserve(ints.size());
std::transform(ints.begin(), ints.end(), std::back_inserter(subs),
[](int subset) -> SubsetIndex { return SubsetIndex(subset); });
return subs;
}
Expand Down Expand Up @@ -197,17 +198,21 @@ PYBIND11_MODULE(set_cover, m) {
return make_iterator<>(IntIterator::begin(model.num_elements()),
IntIterator::end(model.num_elements()));
})
.def_property_readonly("all_subsets",
[](SetCoverModel& model) -> std::vector<BaseInt> {
std::vector<BaseInt> subsets;
std::transform(
model.all_subsets().begin(),
model.all_subsets().end(), subsets.begin(),
[](const SubsetIndex element) -> BaseInt {
return element.value();
});
return subsets;
})
.def_property_readonly(
"all_subsets",
[](SetCoverModel& model) -> std::vector<BaseInt> {
// all_subsets() returns by value, so it must be
// bound to a local: calling it twice would give
// begin() and end() of two distinct temporaries.
const std::vector<SubsetIndex> all = model.all_subsets();
std::vector<BaseInt> subsets;
subsets.reserve(all.size());
std::transform(all.begin(), all.end(), std::back_inserter(subsets),
[](const SubsetIndex element) -> BaseInt {
return element.value();
});
return subsets;
})
.def("set_name", &SetCoverModel::SetName)
.def("add_empty_subset", &SetCoverModel::AddEmptySubset, arg("cost"))
.def(
Expand Down
6 changes: 6 additions & 0 deletions ortools/set_cover/python/set_cover_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,12 @@ def test_knights_cover_trivial(self):
inv.check_consistency(set_cover.consistency_level.FREE_AND_UNCOVERED)
)

def test_all_subsets_property(self):
model = create_knights_cover_model(4, 4)
all_subsets = model.all_subsets
self.assertLen(all_subsets, model.num_subsets)
self.assertEqual(all_subsets, list(range(model.num_subsets)))

# TODO(user): KnightsCoverGreedyAndTabu, KnightsCoverGreedyRandomClear,
# KnightsCoverElementDegreeRandomClear, KnightsCoverRandomClearMip,
# KnightsCoverMip
Expand Down