Skip to content

Add missing argument#3214

Merged
copybara-service[bot] merged 1 commit into
google:masterfrom
bkmgit:quick-reference-fix
Jul 13, 2026
Merged

Add missing argument#3214
copybara-service[bot] merged 1 commit into
google:masterfrom
bkmgit:quick-reference-fix

Conversation

@bkmgit

@bkmgit bkmgit commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@bkmgit bkmgit force-pushed the quick-reference-fix branch from 7b4ec7b to 9f82307 Compare July 13, 2026 07:37
@bkmgit

bkmgit commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

libvips uses this notation:
https://github.com/libvips/libvips/blob/master/libvips/resample/shrinkv_hwy.cpp#L62

Repartitioned types also use the same names:
https://github.com/google/highway/blob/master/hwy/examples/float_distribution.cc#L82

Maybe it is worth doing the same in the source code as libvips ?

@jan-wassenberg

Copy link
Copy Markdown
Member

Thanks for catching. I think this notation is potentially confusing: Rust SIMD and others have adopted a u8x16 notation meaning exactly 16 u8, not "as many u8 as u16". I think it would make more sense to have a h(alf) or q(uarter) suffix. For example, Rebind from u32 to u8 means 1/4 vector.

@bkmgit

bkmgit commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Ok. If one rebinds from u32 to u8, one cannot put the contents directly into u8, so u8quarter is clearer but is a longer expression. Perhaps u8q?

@bkmgit bkmgit force-pushed the quick-reference-fix branch from 9f82307 to a1505b2 Compare July 13, 2026 10:56

@jan-wassenberg jan-wassenberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q is great :) Thanks for updating!

@copybara-service copybara-service Bot merged commit f3f803e into google:master Jul 13, 2026
64 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants