Fix the Multiset code sample in TypeAdapterFactory's JavaDoc - #3114
Closed
alorentiar wants to merge 2 commits into
Closed
Fix the Multiset code sample in TypeAdapterFactory's JavaDoc#3114alorentiar wants to merge 2 commits into
alorentiar wants to merge 2 commits into
Conversation
The sample rejected ImmutableMultiset and HashMultiset because it compared the raw type against Multiset.class instead of using isAssignableFrom, so the multiset fell through to the default collection adapter and duplicates were not aggregated. Mirror the CollectionTypeAdapterFactory pattern and fall back to Object.class for non-parameterized tokens.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Closing this, sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Multiset sample in TypeAdapterFactory's javadoc compared the raw type against Multiset.class, so it rejected ImmutableMultiset and HashMultiset even though those are what most people actually use. The example then fell through to Gson's default collection handling and duplicates were not aggregated.
The sample now uses isAssignableFrom, the same pattern as CollectionTypeAdapterFactory, and falls back to Object.class when the token carries no type information.
Fixes #1335