Support building with JDK 25 - #3104
Open
Marcono1234 wants to merge 2 commits into
Open
Conversation
Marcono1234
force-pushed
the
marcono1234/jdk25-build
branch
from
August 31, 2026 22:29
310ac61 to
eb28299
Compare
Marcono1234
marked this pull request as ready for review
September 1, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Support building with JDK 25
Follow-up for #2847 and #2921
Description
Previously building with JDK 25 was possible (and was done by CI), but was not officially supported.
The underlying issue is that recent JDK builds (at least those from Temurin) do not include
jmodfiles anymore but ProGuard still depends on them.This PR here now adjusts the Maven build config so that it gracefully skips ProGuard and related tests when building with JDK 25 but
jmodfiles are missing.Additionally it uses
actions/setup-java's newjmodfile support to actually test JDK 25 withjmodfiles being present.This means it runs now intentionally two tests for JDK 25 on CI:
jmodfiles: this matches the behavior if a user would use Temurin JDK 25, and ensures that the build worksjmodfiles: this verifies that a full build including ProGuard-related tests works for JDK 25, and also matches the behavior if a user would use a JDK distribution which includesjmodfiles