Skip to content

Wrap IllegalStateException at the AtomicIntegerArray adapter level, consistent with AtomicLongArray #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amitmishra11 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

Wrap IllegalStateException at the AtomicIntegerArray adapter level, consistent with AtomicLongArray #3048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gson/src/main/java/com/google/gson/internal/bind/TypeAdapters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ public AtomicIntegerArray read(JsonReader in) throws IOException {
try {
int integer = in.nextInt();
list.add(integer);
} catch (NumberFormatException e) {
} catch (NumberFormatException | IllegalStateException e) {
throw new JsonSyntaxException(e);
}
}
Expand Down
16 changes: 16 additions & 0 deletions gson/src/test/java/com/google/gson/functional/JavaUtilConcurrentAtomicTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,22 @@ public void testAtomicIntegerArray() {
assertThat(json).isEqualTo("[10,13,14]");
}

@Test
public void testAtomicIntegerArrayWithNullElement() {
JsonSyntaxException e =
assertThrows(
JsonSyntaxException.class, () -> gson.fromJson("[1,null,3]", AtomicIntegerArray.class));
assertThat(e).hasCauseThat().isInstanceOf(IllegalStateException.class);
}

@Test
public void testAtomicIntegerArrayWithNonNumericElement() {
JsonSyntaxException e =
assertThrows(
JsonSyntaxException.class, () -> gson.fromJson("[1,true,3]", AtomicIntegerArray.class));
assertThat(e).hasCauseThat().isInstanceOf(IllegalStateException.class);
}

@Test
public void testAtomicLongArray() {
AtomicLongArray target = gson.fromJson("[10, 13, 14]", AtomicLongArray.class);
Expand Down