Support fork server in engine worker, and expose FuzzTestWorkerInitEarly(). - #2243
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
cl/988262127
branch
5 times, most recently
from
October 1, 2026 17:45
e320b8f to
1e0d76c
Compare
…rly(). This is for supporting migrating runner on top of the engine worker. Previously the runner directly initializes the fork server before creating the watchdog thread. If we want to migrate runner on top of the worker, not only we need to initialize fork server before watchdog, but also do it before the engine worker creating persistent mode socket connection, otherwise the parent process would have the connected socket too and break the invariant needed for persistent mode. PiperOrigin-RevId: 991784397
copybara-service
Bot
force-pushed
the
cl/988262127
branch
from
October 1, 2026 18:07
1e0d76c to
88f66c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support fork server in engine worker, and expose FuzzTestWorkerInitEarly().
This is for supporting migrating runner on top of the engine worker. Previously the runner directly initializes the fork server before creating the watchdog thread. If we want to migrate runner on top of the worker, not only we need to initialize fork server before watchdog, but also do it before the engine worker creating persistent mode socket connection, otherwise the parent process would have the connected socket too and break the invariant needed for persistent mode.