Check more places that can instantiate bad templates.#1462
Open
copybara-service[bot] wants to merge 1 commit into
Open
Check more places that can instantiate bad templates.#1462copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This CL makes us more robust at detecting bad template instantiations.
(Recall that Clang won't tell us directly if trying to instantiate a
template will fail, and even when it does, it will only do so once--
but it leaves behind evidence in the AST that we have to search out.)
* Generalize ForceDefineImplicitFunction and GetInvalidCallTarget.
* ForceDefineImplicitFunction should also work on defaulted decls.
* Extract EnsureFunctionDefined, CheckAndRecurse from GetInvalidCallTarget.
* Check the entire decl in GetInvalidCallTarget instead of just the body (this was missing e.g. initializer expressions in the base case)
* Make sure that special member functions get checked (these can be implicit.)
PiperOrigin-RevId: 949380022
copybara-service
Bot
force-pushed
the
test_949380022
branch
from
July 18, 2026 00:10
94d9eb9 to
451e439
Compare
copybara-service
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check more places that can instantiate bad templates.
This CL makes us more robust at detecting bad template instantiations.
(Recall that Clang won't tell us directly if trying to instantiate a
template will fail, and even when it does, it will only do so once--
but it leaves behind evidence in the AST that we have to search out.)