fix: preserve provider ChatOptions type to prevent ClassCastException - #1337
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_944453292
branch
2 times, most recently
from
July 9, 2026 09:59
327fd0c to
66c1989
Compare
Spring AI OpenAI 2.0.0 casts `Prompt.getOptions()` directly to `OpenAiChatOptions` in `createRequest()` and only substitutes the model's own options when the prompt options are null. ADK built a provider-neutral `DefaultToolCallingChatOptions` whenever tools or generation config were present, so tool-enabled (and config-carrying) requests failed at runtime with: `java.lang.ClassCastException: DefaultToolCallingChatOptions cannot be cast to OpenAiChatOptions`. Build the prompt options on top of the model's own default options (`ChatModel.getOptions()`) via `mutate()`, overlaying the ADK tools and generation config. This keeps the concrete provider type the model expects and preserves provider settings such as API key, base URL, and model name. Falls back to the previous provider-neutral behavior when the model's options are unavailable or not tool-calling capable. PiperOrigin-RevId: 945007278
copybara-service
Bot
force-pushed
the
test_944453292
branch
from
July 9, 2026 10:07
66c1989 to
5c3d328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: preserve provider ChatOptions type to prevent ClassCastException
Spring AI OpenAI 2.0.0 casts
Prompt.getOptions()directly toOpenAiChatOptionsincreateRequest()and only substitutes the model's own options when the prompt options are null. ADK built a provider-neutralDefaultToolCallingChatOptionswhenever tools or generation config were present, so tool-enabled (and config-carrying) requests failed at runtime with:java.lang.ClassCastException: DefaultToolCallingChatOptions cannot be cast to OpenAiChatOptions.Build the prompt options on top of the model's own default options
(
ChatModel.getOptions()) viamutate(), overlaying the ADK tools and generation config. This keeps the concrete provider type the model expects and preserves provider settings such as API key, base URL, and model name. Falls back to the previous provider-neutral behavior when the model's options are unavailable or not tool-calling capable.