test(artifact): cover version lookup after deletion - #1415
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
Problem:
The shared artifact service contract suite verifies that
GetArtifactVersionreturnsfs.ErrNotExistfor an empty service, a missing version, and a missing file, but it does not verify the behavior after an existing artifact is deleted.Solution:
Extend the shared service suite with a post-deletion
GetArtifactVersionassertion. The test runs through the existing in-memory and fake-GCS service implementations and requires an error that matchesfs.ErrNotExist.Testing Plan
Unit Tests:
Passed results:
go test -mod=readonly -count=1 -shuffle=on ./artifact/... ./internal/artifact/...docker run ... golang:1.26.6 go test -race -mod=readonly -count=1 -shuffle=on work(all workspace packages passed; the Windows worktree was copied to a temporary Linux directory to normalize CRLF before running the repository's copyright-header test)go build -mod=readonly workgo build -mod=readonly ./...inplugin/agentanalyticsgolangci-lint run --allow-parallel-runners --new-from-rev=HEADgit diff --checkandgofmtKnown local limitations:
go mod tidy -diffreports a CRLF/LF-only diff on the Windows worktree and does not modify any files.golangci-lint runreports pre-existing gofumpt issues inplatform/*.goandplugin/agentanalytics/*.go; the changed file is clean under--new-from-rev=HEAD.Manual End-to-End (E2E) Tests:
Not applicable: this is a backend contract test with no user-facing runtime change or external service setup.
Checklist
Additional context
No production code or public API behavior is changed.