Update memory to fix issue 1350- 6#1951
Merged
Merged
Conversation
Simplified dense sections, corrected markdown formatting errors, and fixed typos to align with documentation standards. Corrected some sections from the original page and the agent's PR that were a little clunky. Erased sentences inside paragraph's ,Joe's request, and included commas instead. All this while including the necessary update.
-Worked on feedback, fixed errors, changed wording slightly, and reviewed format. -Some changes were lost when I tried to resolve conflicts between branches in my last commit. I added them back here.
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
Thanks! Quick question, why is this a new PR instead of pushing updates to #1361? |
koverholt
approved these changes
Jul 14, 2026
koverholt
left a comment
koverholt
left a comment
Collaborator
There was a problem hiding this comment.
Approving and merging. Thanks for documenting add_memory for #1350 item 6. I verified the memory content against the ADK Python SDK and everything checks out.
I pushed two commits before merging.
In-scope fixes:
- Fixed the
add_memoryexample import:MemoryEntryshould be imported fromgoogle.adk.memory.memory_entry. - Restored
add_events_to_memoryto the operations list and noted that direct-write operations aren't implemented by every service. - Corrected the
## Memory bankheading to## Memory Bankto keep the product name capitalized. - Changed "This entry" to "This method" in the
add_memorybullet.
Out-of-scope cleanup:
- Replaced the truncated Java example with a new
MemoryExample.javareferenced via a snippet include, and verified it compiles against ADK Java 1.6.0. - Renamed the
## In-memory memoryheading to## InMemoryMemoryServicefor readability and consistency with session and artifact pages. - Fixed the undefined
agent_enginereference in the manual-instantiation snippet. - Wrapped prose to ~80 columns, switched bullets from
*to-, and fixed inconsistent tab indentation.
Thanks for the iterations on this one!
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: This PR isolates the memory documentation updates from #1361. Here are the exact changes included:
-Agent (adk-bot) changes: Documented the new add_memory method for direct memory management.
-My changes: Updated memory.md to address the requirements from Issue #1350 - 6 and merged the agent's additions, solved conflics, corrected typos, and did stylistic changes
Deployed: https://deploy-preview-1951--adk-docs-preview.netlify.app/sessions/memory/
PRs: #1361 #1358
Issue: #1350