Ship Windows zips, sign them, and document a Windows signerd host - #18
Merged
Merged
Conversation
GoReleaser Pro builds windows/amd64+arm64 and darwin universals, Authenticode-signs PE when CODESIGN_URL is set, and notarizes macOS when MACOS_SIGN_P12 is set. Windows operators get jsign+PIV docs and a logon Task Scheduler job instead of a Session-0 service. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds signed Windows release artifacts and documents native Windows signerd deployment.
Changes:
- Adds Windows ZIPs, Authenticode signing, and macOS notarization.
- Updates release automation for GoReleaser Pro.
- Adds Windows deployment examples and documentation.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.goreleaser.yaml |
Configures Windows builds, signing, ZIPs, and Darwin universals. |
.github/workflows/release.yml |
Adds signing credentials and GoReleaser Pro. |
init/windows/signexe.sh |
Authenticode-signs Windows executables. |
docs/windows.md |
Documents native Windows hosting. |
docs/yubikey.md |
Mentions WinGet installation. |
README.md |
Links Windows deployment guidance. |
examples/signerd.toml.example |
Documents Windows and PIV settings. |
examples/windows/signerd.toml.example |
Provides Windows jsign configuration. |
examples/windows/signerd.task.xml |
Provides a logon task definition. |
examples/windows/Caddyfile.example |
Provides a Windows reverse-proxy configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
require_and_verify enforces the documented client CA, and 100MiB matches max_body_mib. Co-authored-by: Cursor <cursoragent@cursor.com>
GoReleaser can publish signed-only darwin when the P12 is set but notary secrets are empty. Task Scheduler history is not a log; the example wrapper appends stderr. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CODESIGN_URLis set, Apple notarize whenMACOS_SIGN_P12is set. Release workflow installs this checkout'scodesignCLI and uses goreleaser-pro with a 60m timeout.checksums.txt.Stacked on the Windows config PR. Merge that first.
Test plan
goreleaser release --snapshot --cleanwithoutCODESIGN_URL/MACOS_SIGN_P12: unsigned Windows zips and un-notarized darwin universals, no hook/notary failurechecksums.txtstill cosign-signedcodesign -url http://127.0.0.1:8750 -healthMade with Cursor