Fix osslsigncode Failed to create file on existing -out - #14
Merged
Merged
Conversation
Debian osslsigncode 2.5 fails with "Failed to create file" when -out already exists. publishSigned reserved the staging name by creating an empty file; unlink it so the tool can write the signed PE. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-out(Failed to create file).publishSignedreserved a unique staging name withCreateTemp, which left an empty file. Remove it before invoking the tool./tmp/signerd-*/.output.exe.signing-*).Test plan
go test ./backends/ ./server/ ./cmd/signerd/signerdbinary and re-run the two unstable jobsMade with Cursor