Prevent external capability forgery and support guest RPC bridges - #3836
Open
vigoo wants to merge 3 commits into
Open
Prevent external capability forgery and support guest RPC bridges#3836vigoo wants to merge 3 commits into
vigoo wants to merge 3 commits into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a06cf9-69a4-71ca-8a39-743067900564 Co-authored-by: Amp <amp@ampcode.com>
✅ Deploy Preview for golemcloud canceled.
|
Amp-Thread-ID: https://ampcode.com/threads/T-01a06cf9-69a4-71ca-8a39-743067900564 Co-authored-by: Amp <amp@ampcode.com>
…apabilities Amp-Thread-ID: https://ampcode.com/threads/T-01a06cf9-69a4-71ca-8a39-743067900564 Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # sdks/ts/packages/golem-ts-sdk/tests/tool-registry.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rersolves GOL-181
Summary
Prevent external callers from forging Secret, QuotaToken, and PermissionCard schema values while preserving their use in trusted persistence, replay, and agent-to-agent RPC, including generated guest bridges.
Solution
Separate external JSON from trusted capability transport
Support capabilities in generated guest bridges
Preserve affine ownership
Verification
Implementation validation before rebasing:
Oracle reviewed the implementation milestones and corrective changes. The bounded bug-finder review finished with no open findings.
Post-rebase validation against the latest fetched
origin/main:CARGO_INCREMENTAL=0 cargo check -p golem-cli -p integration-tests --all-targetspassed.CARGO_INCREMENTAL=0 cargo clippy -p golem-cli -p integration-tests --all-targets --no-deps -- -D warningspassed.cargo fmt -p golem-cli -p integration-tests --checkandgit diff origin/main --checkpassed.Validation limitations
concurrentlylookup issue. Direct documentation generation, formatting, and drift checks passed.config.rswas left untouched; the modified fixture source passes its scoped formatting check.