Skip to content

Avoid cloning durable host call responses - #3832

Open
vigoo wants to merge 2 commits into
mainfrom
gol-481-avoid-durable-response-copy
Open

Avoid cloning durable host call responses#3832
vigoo wants to merge 2 commits into
mainfrom
gol-481-avoid-durable-response-copy

Conversation

@vigoo

@vigoo vigoo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move typed durable host-call responses into HostResponse instead of cloning them before persistence
  • return the same owned response through the HostPayloadPair self-roundtrip invariant in both direct and accessor completion paths
  • remove the unnecessary Clone bound while keeping replay conversion fallible and classified as unexpected_oplog_entry

Testing

  • cargo fmt -p golem-common -p golem-worker-executor -- --check
  • cargo clippy -p golem-common -p golem-worker-executor --all-targets --no-deps -- -D warnings
  • cargo check -p golem-common -p golem-worker-executor --all-targets
  • cargo test -p golem-worker-executor --lib -- access_terminal_end_is_appended_before_cleanup_and_permit_release --report-time
  • cargo test -p golem-common --lib -- p3_http_client_consume_body_chunk_host_payload_pairs_roundtrip --report-time

Resolves GOL-481

@vigoo
vigoo requested a review from a team September 4, 2026 12:48
@netlify

netlify Bot commented Sep 4, 2026

Copy link
Copy Markdown

Deploy Preview for golemcloud canceled.

Name Link
🔨 Latest commit 2dcb131
🔍 Latest deploy log https://app.netlify.com/projects/golemcloud/deploys/6a9c237fb3ba420008d6801d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant