Bound invocation result state in worker status - #3820
Open
vigoo wants to merge 6 commits into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a06255-7666-7479-a369-e5d41af95e73 Co-authored-by: Amp <amp@ampcode.com>
✅ Deploy Preview for golemcloud canceled.
|
Amp-Thread-ID: https://ampcode.com/threads/T-01a066ca-8aa9-7107-af16-9fe8171fc87b Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a066ca-8aa9-7107-af16-9fe8171fc87b Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a06255-7666-7479-a369-e5d41af95e73 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentStatusRecordwith a bounded recent exact map plus a fixed-size Bloom filterdesert_rust0.1.11 and derive codecs directly for theim::OrdMap/im::Vector-backed status typesDesign
The hot path stays in memory for recent results and definitive Bloom-filter misses. Once the bounded exact status map evicts older entries, Bloom positives consult the complete physical index. The index records coverage and revert generation, so it is only authoritative after catching up through the status oplog index and cannot return stale results from an obsolete branch. Cold reconstruction and old uncached lookups use bounded oplog chunks rather than retaining an unbounded intermediate map.
Verification
cargo test -p golem-worker-executor --lib worker::status::test -- --report-timecargo test -p golem-worker-executor --lib services::worker::tests -- --report-timecargo test -p golem-worker-executor --lib invocation_result_cache -- --report-timecargo test -p golem-common invocation_result_membership -- --report-timecargo test -p golem-worker-executor --test key_value_storage agent_invocation_result_index -- --report-timecargo check -p golem-worker-executor --libcargo check -p integration-tests --bin benchmarkscargo clippy -p golem-common --all-targets --no-deps -- -D warningscargo clippy -p golem-worker-executor --all-targets --no-deps -- -D warningscargo fmt --all --checkcargo make generate-configsThe new benchmark is compiled but was not run against benchmark infrastructure.
Resolves GOL-175