Chaos testing phase 3 - #3761
Open
kmatasfp wants to merge 69 commits into
Open
Conversation
…refusal correctly
…cross builds" This reverts commit 0ed1fb6.
vigoo
reviewed
Aug 26, 2026
| const VERSION_ON_THE_NEW_BUILD: u32 = 2; | ||
| const VERSION_AFTER_ROLLBACK: u32 = 1; | ||
|
|
||
| pub async fn run( |
Contributor
There was a problem hiding this comment.
There seem to be some confusion in this scenario between component revision and component version. These are not guaranteed to be the same thing with rollbacks
vigoo
reviewed
Aug 26, 2026
| /// account of nothing. | ||
| const WAKE_PROOF_SAMPLE: usize = 5; | ||
|
|
||
| pub async fn run( |
Contributor
There was a problem hiding this comment.
To be checked:
stood_down is a global count. Once any waiter stalls, every unreadable waiter missing a confirmed wakeup is classified as NeverWoke, even if that particular waiter never stood down. One genuine stall plus an unrelated read timeout can therefore produce false violations and fail the scenario.
Fix: retain stalled waiter identities and require both unreadable.contains(agent) and stalled_waiters.contains(agent).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.