Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 95 additions & 0 deletions core/extension/gdextension_interface.json
Original file line number Diff line number Diff line change
Expand Up @@ -3974,6 +3974,101 @@
],
"since": "4.1"
},
{
"name": "print_script_error",
"arguments": [
{
"name": "p_description",
"type": "const char*",
"description": [
"The code triggering the error."
]
},
{
"name": "p_function",
"type": "const char*",
"description": [
"The function name where the error occurred."
]
},
{
"name": "p_file",
"type": "const char*",
"description": [
"The file where the error occurred."
]
},
{
"name": "p_line",
"type": "int32_t",
"description": [
"The line where the error occurred."
]
},
{
"name": "p_editor_notify",
"type": "GDExtensionBool",
"description": [
"Whether or not to notify the editor."
]
}
],
"description": [
"Logs a script error to Godot's built-in debugger and to the OS terminal."
],
"since": "4.8"
},
{
"name": "print_script_error_with_message",
"arguments": [
{
"name": "p_description",
"type": "const char*",
"description": [
"The code triggering the error."
]
},
{
"name": "p_message",
"type": "const char*",
"description": [
"The message to show along with the error."
]
},
{
"name": "p_function",
"type": "const char*",
"description": [
"The function name where the error occurred."
]
},
{
"name": "p_file",
"type": "const char*",
"description": [
"The file where the error occurred."
]
},
{
"name": "p_line",
"type": "int32_t",
"description": [
"The line where the error occurred."
]
},
{
"name": "p_editor_notify",
"type": "GDExtensionBool",
"description": [
"Whether or not to notify the editor."
]
}
],
"description": [
"Logs a script error with a message to Godot's built-in debugger and to the OS terminal."
],
"since": "4.8"
},
Comment on lines +3977 to +4071

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are already on master, at (now) position 14 and 15.
The ones added in this PR are at position 10 and 11 in the same array.

{
"name": "print_script_error",
"arguments": [
{
"name": "p_description",
"type": "const char*",
"description": [
"The code triggering the error."
]
},
{
"name": "p_function",
"type": "const char*",
"description": [
"The function name where the error occurred."
]
},
{
"name": "p_file",
"type": "const char*",
"description": [
"The file where the error occurred."
]
},
{
"name": "p_line",
"type": "int32_t",
"description": [
"The line where the error occurred."
]
},
{
"name": "p_editor_notify",
"type": "GDExtensionBool",
"description": [
"Whether or not to notify the editor."
]
}
],
"description": [
"Logs a script error to Godot's built-in debugger and to the OS terminal."
],
"since": "4.1"
},
{
"name": "print_script_error_with_message",
"arguments": [
{
"name": "p_description",
"type": "const char*",
"description": [
"The code triggering the error."
]
},
{
"name": "p_message",
"type": "const char*",
"description": [
"The message to show along with the error."
]
},
{
"name": "p_function",
"type": "const char*",
"description": [
"The function name where the error occurred."
]
},
{
"name": "p_file",
"type": "const char*",
"description": [
"The file where the error occurred."
]
},
{
"name": "p_line",
"type": "int32_t",
"description": [
"The line where the error occurred."
]
},
{
"name": "p_editor_notify",
"type": "GDExtensionBool",
"description": [
"Whether or not to notify the editor."
]
}
],
"description": [
"Logs a script error with a message to Godot's built-in debugger and to the OS terminal."
],
"since": "4.1"
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I didn't recall having these methods

I don't know if CI would have caught it. The JSON parser may have just had the second one overwrite the first?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we don't see this because of the CI-skipped issue 🤡
I attempted to fix the skip in #121734.

The original duplication might cause a compile error, but different C/C++ compiler versions may be lenient to identical typedefs. To be on the safe side (also in presence of toolchain changes) I also opened #121733.

{
"name": "print_warning",
"arguments": [
Expand Down