Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Validate struct-valued map entries after
endkeyseven when they are held in interfaces, nested pointers, or custom value types. This builds on #1433 by using the normal field traversal instead of checking only the map value's immediate kind.Validation limit: Race testing remains unverified: Windows CGO was unavailable, and the existing Linux environment was stopped.
Implementation and validation
The key-only fallback handled concrete structs and single pointers but silently skipped equivalent wrapped values. Passing the remaining tags, including nil, to
traverseFieldreuses its existing unwrapping, nil handling, and nested-struct validation.VarandStruct, including valid and invalid wrappers, typed nils, nested collections without anotherdive, and custom extraction. Assert error namespaces, JSON field names, tags, parameters, values, kinds, and types.validator_novalidatefnbuild pass.doc.go'snoneofsection produces the same formatting difference on base and head and is left unchanged.The original struct-value fallback was contributed by junaid2005p in #1433. This follow-up does not reopen or claim to newly resolve the original concrete-struct report.
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers