Skip to content

Use Go1.11 module#5743

Merged
lunny merged 8 commits into
go-gitea:masterfrom
typeless:vgo-module
Mar 27, 2019
Merged

Use Go1.11 module#5743
lunny merged 8 commits into
go-gitea:masterfrom
typeless:vgo-module

Conversation

@typeless

@typeless typeless commented Jan 16, 2019

Copy link
Copy Markdown
Contributor

Fixes #5044

Continuing the work in #5069

@typeless typeless changed the title Use Go1.11 module [WIP] Use Go1.11 module Jan 16, 2019
@typeless
typeless force-pushed the vgo-module branch 2 times, most recently from 4b48226 to 1f54ab9 Compare January 16, 2019 11:03
@typeless

typeless commented Jan 16, 2019

Copy link
Copy Markdown
Contributor Author

A roadblock: go-swagger/go-swagger#1681
Maybe there is a workaround.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 16, 2019
@techknowlogick techknowlogick mentioned this pull request Jan 16, 2019
Closed
4 tasks
@techknowlogick techknowlogick added the pr/wip This PR is not ready for review label Jan 17, 2019
@typeless
typeless force-pushed the vgo-module branch 4 times, most recently from 2cd6e12 to 86992bb Compare January 17, 2019 07:03
@typeless

typeless commented Jan 17, 2019

Copy link
Copy Markdown
Contributor Author

It appears that any go build/go get when running make under a module would modify the go.mod, which would complicates the migration. So, I chose a more conservative approach, setting GO111MODULE=on only for make build and make test-*. Otherwise, always setting GO111MODULE=off.

@typeless

typeless commented Jan 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

For now, the remaining problem is the integration test of mssql does not pass. The test is about the API of the releases. Both the POST succeeded, but the GET and PATCH failed.

@typeless
typeless force-pushed the vgo-module branch 12 times, most recently from e46470f to 9d0bd32 Compare January 21, 2019 07:50
@sapk

sapk commented Jan 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

A roadblock: go-swagger/go-swagger#1681
Maybe there is a workaround.

I could re-test but if the deps are still vendored with go mod vendor, it should be fine as the libs will be in the GOPATH (./vendor folder).

Otherwise, there is a PR (that I should update) for the git lib : go-gitea/git#134

@typeless

typeless commented Jan 21, 2019

Copy link
Copy Markdown
Contributor Author

@sapk Yeah, I leave swagger's dependencies in GOPATH. Now, the outstanding problem is the failure of the mssql test.

@typeless
typeless force-pushed the vgo-module branch 2 times, most recently from 8365b79 to 65eb04c Compare January 21, 2019 14:29
@codecov-io

codecov-io commented Jan 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5743 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5743      +/-   ##
==========================================
- Coverage   39.41%   39.39%   -0.02%     
==========================================
  Files         393      393              
  Lines       53264    53264              
==========================================
- Hits        20992    20986       -6     
- Misses      29285    29292       +7     
+ Partials     2987     2986       -1
Impacted Files Coverage Δ
modules/markup/html.go 83.29% <ø> (ø) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d578b71...01d9a7a. Read the comment docs.

@typeless

typeless commented Feb 18, 2019

Copy link
Copy Markdown
Contributor Author

Done.

lunny
lunny requested changes Feb 18, 2019
View reviewed changes
Comment thread Makefile Outdated
@lunny

lunny commented Feb 28, 2019

Copy link
Copy Markdown
Member

conflicted

@typeless

typeless commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

I am quite busy on my day job recently. To resolve the conflicts, I sometimes need to re-do the migration process, which is not super difficult in itself but does take some time and carefulness.

I'll find time to work on this in the coming weeks.
If this would block the progress of certain changes, feel free to let me know.

@sapk

sapk commented Mar 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Conflicts should come from a new (replacement) lib f2de5dc and the update of code.gitea.io/git
50631b5

@typeless
typeless force-pushed the vgo-module branch 4 times, most recently from abccfd1 to f3817db Compare March 26, 2019 08:30
@typeless

typeless commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

Updated

@lunny lunny added this to the 1.9.0 milestone Mar 26, 2019
@lunny

lunny commented Mar 27, 2019

Copy link
Copy Markdown
Member

@typeless please resolve conflicted.

@typeless

typeless commented Mar 27, 2019

Copy link
Copy Markdown
Contributor Author

Done

@lunny
lunny merged commit d771769 into go-gitea:master Mar 27, 2019
@typeless
typeless deleted the vgo-module branch April 3, 2019 04:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks left review comments
@lunny lunny lunny approved these changes
@techknowlogick techknowlogick techknowlogick approved these changes
+4 more reviewers
@kolaente kolaente kolaente left review comments
@appleboy appleboy appleboy approved these changes
@sapk sapk sapk approved these changes
@adelowo adelowo adelowo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

Migrate from dep to golang modules (vgo)