fix(auth): restrict oauth2 login avatar fetch to external hosts#38290
Open
insaf021 wants to merge 3 commits into
Open
fix(auth): restrict oauth2 login avatar fetch to external hosts#38290insaf021 wants to merge 3 commits into
insaf021 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oauth2UpdateAvatarIfNeeddownloads the avatar URL handed over by the login provider (gothUser.AvatarURL, i.e. the OIDCpictureclaim) with a bare client:Webhook and migration egress is already funnelled through
hostmatcher.NewDialContext, but this fetch was not, so withOAUTH2_CLIENT.UPDATE_AVATARon, a hostile picture value drives a server-side GET to internal targets on sign-in:http://169.254.169.254/...cloud metadata, loopback admin panels, RFC1918 hosts.Route the avatar client through the same dialer with a
MatchBuiltinExternalallow-list so only public hosts are reachable, the same default the webhook client uses. Built viasync.OnceValueso proxy settings are read after config load rather than at package init.Checked the resulting dialer rejects
127.0.0.1,169.254.169.254,10.0.0.0/8and192.168.0.0/16while public hosts still resolve.