cleanup: replace deprecated needs.activation.outputs.{text,title,body} in examples and fixtures#43743
Conversation
needs.activation.outputs.{text,title,body} in examples and fixtures
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ No review possible: PR #43743 contains no actual code changes. The single commit is 'Initial plan' with 0 additions, 0 deletions, and 0 changed files. The PR describes the intended cleanup (replacing deprecated needs.activation.outputs references in docs/fixtures/tests) but has not been implemented yet. Review will be possible once the changes are committed to the branch. |
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (0 additions detected). |
There was a problem hiding this comment.
Review: No code changes to evaluate
This PR currently has 0 additions, 0 deletions across 0 changed files. The only commit is titled "Initial plan" with no file diff. The changes described in the PR body (updating architecture.mdx, compile_security_benchmark_test.go, and runtime_import.test.cjs) have not yet been committed.
Nothing to review until the implementation commits land.
🔎 Code quality review by PR Code Quality Reviewer · 22.3 AIC · ⌖ 5.15 AIC · ⊞ 5.5K
Comment /review to run again
The deprecated
needs.activation.outputs.{text,title,body}pattern kept surfacing in docs and test fixtures, causing author confusion. The compiler auto-transforms this pattern tosteps.sanitized.outputs.*at build time, so examples should model the correct form directly.Changes
docs/src/content/docs/introduction/architecture.mdx– update Mermaid diagram sanitization output node label fromneeds.activation.outputs.text→steps.sanitized.outputs.textpkg/cli/compile_security_benchmark_test.go– update example workflow content used as benchmark inputactions/setup/js/runtime_import.test.cjs– update two tests that used the deprecated expression as a generic placeholder; expected placeholder name updated accordingly (__GH_AW_NEEDS_ACTIVATION_OUTPUTS_TEXT__→__GH_AW_STEPS_SANITIZED_OUTPUTS_TEXT__)Not changed
Tests that specifically exercise the transformation path (
expression_extraction_test.go,codemod_activation_outputs_test.go, fuzz seeds) intentionally retain the old pattern as their input—removing it there would break coverage of the backward-compat rewrite logic.