docs(java): add ADR-007 native runtime bundling strategy#1923
Merged
Conversation
Documents the decision to distribute the Rust Copilot runtime as per-platform classifier JARs (DJL style) rather than a monolithic all-platform JAR or download-on-demand. Covers: platform dimensions (6 or 8 Rust target triples), 100% deterministic platform selection via os.name/os.arch/ELF PT_INTERP, measured binary sizes from cli-1.0.69-2, comparables (ONNX Runtime, DJL, SQLite JDBC), and a references section defining FFI, JNA, napi-rs, cdylib, C ABI, ELF, glibc, musl, MSVC CRT, DJL, os-maven-plugin, and ONNX Runtime for readers unfamiliar with the native binary ecosystem. Related: #1917 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Java ADR documenting the decision to bundle the Rust Copilot runtime using per-platform classifier JARs (DJL-style), including platform selection rationale and size tradeoffs, as part of planning for Java native runtime embedding (Issue #1917).
Changes:
- Introduces ADR-007 describing
runtime.nodeartifact characteristics and the stable C ABI “front door” used for in-process loading via JNA. - Documents platform matrix (OS/arch/libc), deterministic platform selection, and measured binary size baselines.
- Evaluates three distribution options and records the decision to use per-platform classifier JARs, with consequences and references.
Show a summary per file
| File | Description |
|---|---|
java/docs/adr/adr-007-native-bundling-strategy.md |
New ADR defining the native runtime bundling/distribution strategy for the Java SDK. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 4
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the decision to distribute the Rust Copilot runtime as per-platform classifier JARs (DJL style) rather than a monolithic all-platform JAR or download-on-demand.
Covers: platform dimensions (6 or 8 Rust target triples), 100% deterministic platform selection via os.name/os.arch/ELF PT_INTERP, measured binary sizes from cli-1.0.69-2, comparables (ONNX Runtime, DJL, SQLite JDBC), and a references section defining FFI, JNA, napi-rs, cdylib, C ABI, ELF, glibc, musl, MSVC CRT, DJL, os-maven-plugin, and ONNX Runtime for readers unfamiliar with the native binary ecosystem.
Related: #1917