support unbundled multihomed servers in SetupVPCs / TestConnectivity - #1836
Closed
edipascale wants to merge 6 commits into
Closed
support unbundled multihomed servers in SetupVPCs / TestConnectivity#1836edipascale wants to merge 6 commits into
edipascale wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
edipascale
force-pushed
the
ema/multiple-conns-unbundled
branch
from
June 23, 2026 10:04
604bcb0 to
4484d75
Compare
edipascale
force-pushed
the
ema/test-connectivity
branch
from
June 23, 2026 13:42
3d9ba10 to
3361aa3
Compare
edipascale
force-pushed
the
ema/multiple-conns-unbundled
branch
from
June 23, 2026 13:43
4484d75 to
471d99e
Compare
edipascale
marked this pull request as ready for review
June 24, 2026 08:02
pau-hedgehog
force-pushed
the
ema/test-connectivity
branch
from
July 9, 2026 20:58
3361aa3 to
564a871
Compare
edipascale
force-pushed
the
ema/test-connectivity
branch
from
July 10, 2026 13:51
564a871 to
5549eab
Compare
edipascale
force-pushed
the
ema/multiple-conns-unbundled
branch
from
July 13, 2026 13:22
471d99e to
d99cb50
Compare
pau-hedgehog
force-pushed
the
ema/test-connectivity
branch
from
July 14, 2026 17:53
5549eab to
cd3dc5b
Compare
edipascale
force-pushed
the
ema/test-connectivity
branch
from
July 15, 2026 09:58
cd3dc5b to
e47a567
Compare
edipascale
force-pushed
the
ema/multiple-conns-unbundled
branch
from
July 15, 2026 09:59
d99cb50 to
340084b
Compare
edipascale
force-pushed
the
ema/test-connectivity
branch
from
July 22, 2026 06:46
e47a567 to
ce28f3b
Compare
edipascale
force-pushed
the
ema/multiple-conns-unbundled
branch
from
July 22, 2026 06:46
340084b to
c430b6d
Compare
replace a number of ad-hoc testing function with a declarative, matrix-based test. Reachability checks that are currently supported by Fabric are preserved as is; additional checks are manually overlayed on the matrix, e.g. for NAT tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
Move endpoint collection out of SetupVPCs into a standalone, inspection- based helper (CollectServerEndpoints in pkg/hhfab/endpoints.go) so the matrix can model servers with multiple (vpc, subnet) attachments, be built against pre-existing topologies, and be refreshed per-server after a runtime config change. SetupVPCs now delegates to the collector after configuring servers and keeps its ([]*Endpoint, error) signature. BuildConnectivityMatrixFromCluster covers the build-from-scratch case. ReplaceServerEndpoints on the matrix swaps endpoint pointers and wipes stale entries; rebindMatrixServerEndpoint in the overlap-NAT test now reads (vpc, subnet) from the cluster instead of being told. The single-IP discoverServerIP is replaced by discoverServerIPs; the legacy non-matrix TestConnectivity asserts len==1 itself. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
ensure that followup failover test have up-to-date information Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
edipascale
force-pushed
the
ema/test-connectivity
branch
from
July 28, 2026 14:42
ce28f3b to
acb7a48
Compare
Replace single-connection/subnet args of getServerHostBGPCmd with a []HostBGPParams slice so the helper can compose configs for hosts attached to multiple hostBGP VPCs over multiple connections. Each entry carries VPC label, connections, VLAN, subnet, and per-server address offset. Updates the two existing call sites (SetupVPCs and the on-ready release test) to pass a single-element slice; behavior is unchanged. Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
automatically opt for a hostBGP subnet if a server has multiple unbundled connections. also detect this setup in test-connectivity and treat it as a single endpoint Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
the standard topology has 2 eslag leaves and 1 orphan, and we want to be able to test hostbgp with this. vlab gen now prefers orphan leaves for mh servers but will take eslag leaves too if there are not enough orphans Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
edipascale
force-pushed
the
ema/multiple-conns-unbundled
branch
from
July 28, 2026 14:43
c430b6d to
ef68a37
Compare
edipascale
force-pushed
the
ema/test-connectivity
branch
from
July 29, 2026 16:03
acb7a48 to
709bff4
Compare
Contributor
Author
|
closing in favor of #1910 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stacked on top of the connectivity matrix refactor