Skip to content

test: make network auth fetch regression test deterministic#21

Draft
bschellenberger2600 wants to merge 1 commit into
mainfrom
cursor/fix-auth-fetch-test-0301
Draft

test: make network auth fetch regression test deterministic#21
bschellenberger2600 wants to merge 1 commit into
mainfrom
cursor/fix-auth-fetch-test-0301

Conversation

@bschellenberger2600

@bschellenberger2600 bschellenberger2600 commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary

Replace the external-network auth regression test with a local HTTP auth challenge so it validates non-interactive git behavior deterministically.

Why this change?

make test-race on current main fails in internal/git because the test depends on a GitHub URL whose failure mode changed to repository not found, so the test no longer reliably exercises the terminal-prompt-disabled path.

Bug Reproducibility (if this fixes a bug)

  • Repro steps:
    1. Check out main at latest head after 3b65f5e.
    2. Run make test-race.
    3. Observe TestNetworkFetch_UnauthenticatedHTTPSFailsWithoutPrompt fail with unexpected auth/error text.
  • If reproducibility steps are not feasible, explain why:

Tests

  • I added or updated tests for all code changes in this PR.
  • For bug fixes, I added regression coverage.
  • I ran go test -race -count=1 ./....
  • I ran go vet ./....

Risk / Rollback Notes (optional)

Low risk: only test code changed. Rollback by reverting this commit if needed.

Open in Web Open in Cursor 

Co-authored-by: Ben Schellenberger <bschellenberger2600@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 044e1306-841c-4c54-85ce-8fc1cad60745

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-auth-fetch-test-0301

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants