fix(core): Fixes for initialization tracking of render targets - #10060
Open
andyleiserson wants to merge 5 commits into
Open
fix(core): Fixes for initialization tracking of render targets#10060andyleiserson wants to merge 5 commits into
andyleiserson wants to merge 5 commits into
Conversation
Derive `TextureInitRange` from `TextureView`, rather than `TextureSelector`. Unambiguous conversion requires knowing whether the texture is 3D.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes initialization tracking when depth slices of 3D textures are used as render targets, and also for div/reconvergent depth/stencil. Comprised of 5 commits:
ReadbackBuffershelper to cover MIP levels, depth slices, and array layers.TextureInitRangeto be constructed from aTextureViewrather than aTextureSelector. Knowing the dimension of the texture is necessary to set the layer range properly.StoreOp::Discard, we must reinitialize that depth slice before the end of the command buffer (including before use in later commands, if applicable, and being careful to leave live data in other slices untouched).Fixes #9455.
Testing
Enables CTS tests and adds directed tests.
Squash or Rebase? Rebase (after squashing any fixups)
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.