Extract IDs, Registries and Global into wgpu-core-remote - #10053
Open
sagudev wants to merge 5 commits into
Open
Conversation
8 tasks
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
sagudev
force-pushed
the
wgpu-core-remote
branch
from
August 12, 2026 16:59
60f7b84 to
add7a20
Compare
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
sagudev
marked this pull request as ready for review
August 12, 2026 18:05
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
teoxoy
approved these changes
Aug 13, 2026
Member
|
Thoughts on removing ray tracing and presentation/surface functionality from the remote crate? Or more generally things that are not in the spec and also not useful to browser implementations. Shader cache might be interesting to keep - or not due to security concerns. |
Collaborator
Author
Yes, tho I planned that for follow ups to keep this PR with minimal decisions. We should also remove optional ids, and non ided global methods. |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Finally fixes #5121
Description
Move IDs, Registries and Global into wgpu-core-remote to be used by servo and firefox. This PR tries to achieve this with minimal changes, so it's mainly just moving stuff around and fixing imports. Future cleanups are noted in #5121 (comment)
Cargo and lib.rs are adapted from wgc. Because of tracing, we need to keep markers in wgc. To avoid complication with features and build scripts I removed some backend feature gated surface methods and one that is gated on tracing feature (if one needs them they are available in wgc::Device directly, but browsers do not use them anyway). So it's users are expected to depend on wgc directly for future selection. We use normal parking_lot instead of lock rank stuff as we we will remove them in the future anyway.
Testing
It compiles, but otherwise untested. We could implement wgpu custom backend using remoting, but maybe we can just trust that it works.
Squash or Rebase?
Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.