ref(perf): Remove projects:workflow-engine-performance-detectors flag#119033
Draft
cvxluo wants to merge 1 commit into
Draft
ref(perf): Remove projects:workflow-engine-performance-detectors flag#119033cvxluo wants to merge 1 commit into
cvxluo wants to merge 1 commit into
Conversation
Remove the flagpole-disabled projects:workflow-engine-performance-detectors feature flag and the workflow-engine performance-detector migration code it gated. The flag was never enabled (it is not present in sentry-options-automator), so behavior now defaults to the flag being off: performance detection always uses ProjectOption-based settings, and the settings endpoint no longer syncs to or auto-creates WFE Detectors. The shared detector type mappings remain, as they are used elsewhere. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MTV5tNMyvqCcf2L7B6p5c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
projects:workflow-engine-performance-detectors. This flag was never rolled out (it is not present in sentry-options-automator); the WFE performance-detector migration code it gated was added in #107137 (merged 2/27) and has not been enabled since.Behavior now defaults to the flag being off:
get_merged_settings/get_detection_settingsalways use ProjectOption-based (LEGACY) settings; thesettings_mode/SettingsModeWFE path and its helpers are removed.Shared detector type mappings (
PERFORMANCE_DETECTOR_CONFIG_MAPPINGS,PERFORMANCE_WFE_DETECTOR_TYPES) are kept since they're used elsewhere. Flag registration removed fromtemporary.py.Generated by Claude Code