Skip to content

[DRAFT] Remove query_builder from mypy typing-issues list#119028

Draft
cursor[bot] wants to merge 3 commits into
masterfrom
cursor/untyped-module-cleanup-f03a
Draft

[DRAFT] Remove query_builder from mypy typing-issues list#119028
cursor[bot] wants to merge 3 commits into
masterfrom
cursor/untyped-module-cleanup-f03a

mypy: tighten query_builder annotations

dc45d92
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Jul 4, 2026 in 0s

1 issue

High

parse_public_field uses MRI regex instead of public-name regex, breaking all public metric field parsing - `src/sentry/snuba/metrics/query_builder.py:130-134`

Replacing PUBLIC_EXPRESSION_REGEX.match(field) with parse_expression(field) is incorrect: parse_expression uses MRI_EXPRESSION_REGEX which requires MRI format (entity:namespace/name@unit), so public fields like sum(session.duration) never match, causing operation=None and metric_name="sum(session.duration)", which then fails inside get_mri() with InvalidParams("Failed to parse 'sum(session.duration)'") for every API call with a public metric field.

6 skills analyzed
Skill Findings Duration Cost
security-review 0 10.9s $0.10
sentry-backend-bugs 1 5m 25s $0.90
wrdn-pii 0 14.3s $0.13
wrdn-authz 0 14.1s $0.11
wrdn-code-execution 0 16.9s $0.10
wrdn-data-exfil 0 20.1s $0.10

⏱ 6m 41s · 1.1M in / 23.3k out · $1.46