fix(transport): Restore reqwest protocol features#1258
Merged
Conversation
lcian
force-pushed
the
fix/restore-reqwest-transport-features
branch
from
July 22, 2026 13:48
6adf8bd to
0500722
Compare
lcian
changed the title
lcian
marked this pull request as ready for review
July 22, 2026 13:56
szokeasaurusrex
approved these changes
Jul 22, 2026
This comment has been minimized.
This comment has been minimized.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0500722. Configure here.
lcian
changed the title
lcian
marked this pull request as draft
July 22, 2026 14:18
lcian
marked this pull request as ready for review
July 22, 2026 14:18
Use native TLS without ALPN and stop enabling HTTP/2 so the reqwest 0.13 transport retains the protocol behavior from reqwest 0.12.
lcian
force-pushed
the
fix/restore-reqwest-transport-features
branch
from
July 22, 2026 15:02
0500722 to
640f8c7
Compare
szokeasaurusrex
approved these changes
Jul 22, 2026
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 640f8c7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #998 we upgraded
reqwestto0.13.x.We moved from
reqwest/default-tlstoreqwest/native-tls. The two features are not exactly equivalent, as the second one additionally enables ALPN.Along with that, we enabled its
http2feature flag, which was not enabled by default in0.12.x.The original author of that PR enabled
http2as a doctest was failing.Apparently it was failing due to this bug in reqwest seanmonstar/reqwest#2927, where enabling only ALPN but not HTTP2 would cause a runtime panic, as the client still advertised HTTP 2 even though it was compiled without support for it.
Enabling HTTP2 is not a problem for
sentryitself, but it can be if an application crate usesreqwest(independently) +sentry, as upgradingsentrymight silently enable HTTP2 on the unifiedreqwestdependency.This PR restores the previous protocol feature set by selecting
native-tls-no-alpn, and removinghttp2.It also bumps
reqwestto0.13.2to get the fix for the aforementioned bug in. Otherwise, if a user has exactly version0.13.1as a direct dependency, and enables ALPN but not HTTP2, the reqwest transport will run exactly into that bug, and panic.Close #1057