Skip to content

build(cargo): Centralize dependency declatations#1242

Open
szokeasaurusrex wants to merge 2 commits into
masterfrom
szokeasaurusrex/inherit-deps
Open

build(cargo): Centralize dependency declatations#1242
szokeasaurusrex wants to merge 2 commits into
masterfrom
szokeasaurusrex/inherit-deps

Conversation

@szokeasaurusrex

Copy link
Copy Markdown
Member

Centralize dependency declarations by moving them to the workspace-level Cargo.toml.

This PR contains two commits:

  • 2e0608c is fully generated by cargo autoinherit.
  • 123f38a re-enables a crate feature, which got disabled by cargo autoinherit because if default-features = false is used for a dependency in one of the workspace members, then this gets centralized in the workspace.

This does not centralize all dependency declarations, because cargo autoinherit skips some things, but most everything is centralized now.

Centralize dependency declarations by moving them to the workspace-level `Cargo.toml`.

The changes in this commit were generated with [`cargo autoinherit`](https://github.com/mainmatter/cargo-autoinherit)
`cargo autoinherit` adds `default-features = false` to the workspace definition if used by any of the crate-level dependencies. For most deps, this was apparently fine, but for `actix-web`, we need the `macros` feature in `sentry-actix` dev dependencies.
@szokeasaurusrex
szokeasaurusrex requested a review from a team as a code owner July 20, 2026 11:44
@szokeasaurusrex
szokeasaurusrex requested a review from Litarnus July 20, 2026 11:44
Comment thread Cargo.lock

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lock file changes appear to happen because cargo autoinherit centralized us on default-features = false for some reps, deactivating some unused features.

cursor[bot]

This comment was marked as low quality.

@linear-code

linear-code Bot commented Jul 20, 2026

Copy link
Copy Markdown

RUST-266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants