Skip to content

feat(data-collection): Request data collection#3030

Open
sl0thentr0py wants to merge 1 commit into
neel/data-collection/userfrom
neel/data-collection/request
Open

feat(data-collection): Request data collection#3030
sl0thentr0py wants to merge 1 commit into
neel/data-collection/userfrom
neel/data-collection/request

Conversation

@sl0thentr0py

@sl0thentr0py sl0thentr0py commented Jul 21, 2026

Copy link
Copy Markdown
Member
  • Add PII_HEADER_SNIPPETS to backfill
  • Use data_collection.http_headers.request for ip address collection (both env and request)
    • Sensitive headers like auth and cookies are now ALWAYS filtered unlike before
  • Use data_collection.cookies for cookie collection (fix Hash signature since it always was one)
  • Use data_collection.url_query_params for query string and parse query into Hash and filter
  • Use data_collection.http_bodies for body
    • JSON is also parsed and filtered now, form data is also filtered for sensitive keys
  • Deprecate rack_env_whitelist, will be removed in major

Issues

Comment thread sentry-ruby/lib/sentry/interfaces/request.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch 4 times, most recently from 84ceec2 to e36c648 Compare July 21, 2026 15:21
@linear-code

linear-code Bot commented Jul 21, 2026

Copy link
Copy Markdown

RUBY-191

@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch 2 times, most recently from ceb85b7 to 6a366a2 Compare July 22, 2026 11:39
Comment thread sentry-ruby/lib/sentry/interfaces/request.rb Outdated
Comment thread sentry-ruby/lib/sentry/interfaces/request.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch 2 times, most recently from f50f49d to 5543891 Compare July 22, 2026 11:49
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/user branch from 4decfb9 to 890905f Compare July 22, 2026 11:49
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch 2 times, most recently from 134f992 to a3638b2 Compare July 22, 2026 11:52
Comment thread sentry-ruby/lib/sentry/interfaces/request.rb Outdated
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch from a3638b2 to 1202c30 Compare July 22, 2026 12:00
Comment thread sentry-ruby/lib/sentry/interfaces/request.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/user branch from 890905f to 2123a14 Compare July 22, 2026 12:07
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch from 1202c30 to e12f4a2 Compare July 22, 2026 12:10
Comment thread sentry-ruby/lib/sentry/configuration.rb
Comment thread sentry-ruby/lib/sentry/data_collection.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/user branch from 2123a14 to 890905f Compare July 22, 2026 12:13
Comment thread sentry-ruby/lib/sentry/interfaces/request.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/user branch from 890905f to 14a6918 Compare July 22, 2026 12:14
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch 3 times, most recently from a207aae to 831da33 Compare July 22, 2026 12:23

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 831da33. Configure here.

Comment thread sentry-ruby/lib/sentry/interfaces/request.rb Outdated
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch 2 times, most recently from f1e317b to b6161d4 Compare July 22, 2026 13:13
Comment thread sentry-ruby/lib/sentry/interfaces/request.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch from b6161d4 to 612525c Compare July 22, 2026 13:26
Co-Authored-By: OpenAI <noreply@example.com>
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/user branch from 14a6918 to dfab328 Compare July 22, 2026 16:19
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch from 612525c to bdfab90 Compare July 22, 2026 16:19
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/user branch from dfab328 to c093e44 Compare July 22, 2026 16:19
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/request branch 2 times, most recently from 4d4eaa4 to bdfab90 Compare July 22, 2026 16:23
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/user branch from c093e44 to dfab328 Compare July 22, 2026 16:23
Comment thread sentry-ruby/lib/sentry/data_collection.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(pii): Wire core request interface to data_collection

1 participant