feat(astro)!: Remove unstable_sentryVitePluginOptions - #23370
Open
Conversation
Contributor
size-limit report 📦
|
chargome
force-pushed
the
charlygomez/js-3358-astro-remove-unstable_sentryvitepluginoptions
branch
from
August 12, 2026 14:51
38665cc to
265e7ba
Compare
chargome
changed the base branch from
charlygomez/js-3355-core-add-build-time-options-for-bundler-plugin-parity
to
charlygomez/js-3361-sveltekit-remove-unstable_sentryvitepluginoptions
August 12, 2026 14:51
chargome
force-pushed
the
charlygomez/js-3358-astro-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 09:28
265e7ba to
f36f76b
Compare
chargome
force-pushed
the
charlygomez/js-3358-astro-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 09:44
f36f76b to
72ed096
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chargome
force-pushed
the
charlygomez/js-3358-astro-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 10:02
72ed096 to
365eee0
Compare
chargome
force-pushed
the
charlygomez/js-3358-astro-remove-unstable_sentryvitepluginoptions
branch
2 times, most recently
from
August 13, 2026 11:45
94eaa37 to
e123255
Compare
chargome
force-pushed
the
charlygomez/js-3358-astro-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 12:26
e123255 to
b79a3ff
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b79a3ff. Configure here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3358-astro-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 13:17
b79a3ff to
c4990d7
Compare
chargome
marked this pull request as ready for review
August 13, 2026 13:45
chargome
requested review from
mydea and
s1gr1d
and removed request for
a team
August 13, 2026 13:45
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
|
||
| expectTypeOf(viteOptions).toEqualTypeOf<SentryOptions>(); | ||
| expectTypeOf(options).toEqualTypeOf<SentryOptions>(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: The type test for unstable_sentryVitePluginOptions is misleading. expectTypeOf(options).toEqualTypeOf<SentryOptions>() passes trivially because options is explicitly annotated, not because the extra property is correctly handled.
Severity: LOW
Suggested Fix
Remove the expectTypeOf(options).toEqualTypeOf<SentryOptions>() assertion. The @ts-expect-error comment is sufficient on its own to test and document that TypeScript correctly flags the deprecated property as an error.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/astro/test/buildOptions.test-d.ts#L147
Potential issue: The type test at `buildOptions.test-d.ts:147` is intended to verify
that the deprecated `unstable_sentryVitePluginOptions` property is rejected by the
`SentryOptions` type. However, the test is flawed. It uses `@ts-expect-error` to
suppress the type error on assignment, but then asserts
`expectTypeOf(options).toEqualTypeOf<SentryOptions>()`. Because the `options` variable
is explicitly annotated with the `SentryOptions` type, this assertion simply compares
the type to itself and always passes. It does not actually verify that an object with
the extra property is considered a different type, making the test ineffective and
providing a false sense of security.
Did we get this right? 👍 / 👎 to inform future reviews.
nicohrubec
approved these changes
Aug 13, 2026
s1gr1d
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
unstable_sentryVitePluginOptionsfrom the Astro integration options — both the top-level option and the deprecated copy insidesourceMapsUploadOptions.Everything it exposed is reachable as a top-level build option. Adds a build-time warning, routed through Astro's integration logger.
The warning matters more here than elsewhere:
SentryOptionsintersectsRecord<string, unknown>, so TypeScript accepts any key and would otherwise leave the removal entirely silent. The key is also excluded from the generic "additional options" warning, which would wrongly tell users to move it into theirsentry.client.configfile.Fixes #23342