docs(feature-flags): Clarify feature flag buffer behavior#18671
Draft
adinauer wants to merge 1 commit into
Draft
docs(feature-flags): Clarify feature flag buffer behavior#18671adinauer wants to merge 1 commit into
adinauer wants to merge 1 commit into
Conversation
Clarify scope and span feature flag buffer requirements so SDKs enforce limits while allowing platform-specific values. Document where feature flag APIs should be exposed and how scope and span feature flags map to payloads. Refs GH-18660 Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
romtsn
reviewed
Jul 8, 2026
|
|
||
| #### Span Storage | ||
|
|
||
| Span feature flags provide context for individual spans. SDKs that track feature flags on spans **MUST** enforce a maximum number of unique evaluations per span (e.g. 10). |
Member
There was a problem hiding this comment.
maybe say 10 is the recommended value ("e.g. 10" doesn't read like that)
romtsn
reviewed
Jul 8, 2026
|
|
||
| Child spans **MUST NOT** inherit feature flags from parent spans. | ||
|
|
||
| If an SDK tracks both scope and span feature flags, adding a feature flag through a scope-level or top-level API while a span is active **MUST** also record the evaluation on the active span, subject to the span limit. |
Member
There was a problem hiding this comment.
maybe say "subject to the rules listed above"? I'm guessing if a flag already exists on the active span, we'd also update it there when adding it to the scope?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the feature flag SDK spec added in #18660 with the behavior captured from the sentry-java implementation plan.
This documents scope and span buffer behavior, including uniqueness, SDK-defined limits, scope cloning and merging, span inheritance, payload mapping, and where
add_feature_flag/clear_feature_flagsshould be exposed.The limits are intentionally specified as SDK-enforced limits with recommended values, rather than fixed cross-SDK requirements, because different SDKs may need different values based on platform constraints.
Refs #18660
Refs getsentry/sentry-java#4763