Skip to content

feat(devdocs): Add guidance for updating sample_rate#18645

Open
sentrivana wants to merge 6 commits into
masterfrom
ivana/add-sample-rate-update
Open

feat(devdocs): Add guidance for updating sample_rate#18645
sentrivana wants to merge 6 commits into
masterfrom
ivana/add-sample-rate-update

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

At some point last year, we implemented sample rate updating under specific conditions in most SDKs. This is missing from the spec.

Original implementation ticket: getsentry/team-sdks#117

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

At some point last year, we implemented sample rate updating under specific conditions in most SDKs. This is missing from the spec.

Original implementation ticket: getsentry/team-sdks#117
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Jul 6, 2026 11:33am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
sentry-docs Ignored Ignored Preview Jul 6, 2026 11:33am

Request Review

@github-actions github-actions Bot added the sdk-develop-docs PRs touching develop-docs/sdk label Jul 6, 2026
Comment thread develop-docs/sdk/foundations/trace-propagation/index.mdx
@sentrivana sentrivana requested a review from cleptric July 6, 2026 11:33
@sentrivana sentrivana changed the title feat(devdocs): Add guidance wrt to updating sample_rate feat(devdocs): Add guidance for updating sample_rate Jul 6, 2026

@cleptric cleptric left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this was about making sure that the DSC in the trace envelope header has the correct sample rate. The baggage propagated downstream does not need to be updated afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-develop-docs PRs touching develop-docs/sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants