feat(devdocs): Add guidance for updating sample_rate#18645
Open
sentrivana wants to merge 6 commits into
Open
Conversation
At some point last year, we implemented sample rate updating under specific conditions in most SDKs. This is missing from the spec. Original implementation ticket: getsentry/team-sdks#117
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
alexander-alderman-webb
approved these changes
Jul 6, 2026
sample_ratesample_rate
cleptric
reviewed
Jul 6, 2026
cleptric
left a comment
Member
There was a problem hiding this comment.
IIRC, this was about making sure that the DSC in the trace envelope header has the correct sample rate. The baggage propagated downstream does not need to be updated afaik.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point last year, we implemented sample rate updating under specific conditions in most SDKs. This is missing from the spec.
Original implementation ticket: getsentry/team-sdks#117
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: