Skip to content

capture and validate Stripe Checkout screenshots - #8956

Open
atavism wants to merge 4 commits into
atavism/issue-3723from
atavism/issue-3723-payment-screenshot
Open

capture and validate Stripe Checkout screenshots#8956
atavism wants to merge 4 commits into
atavism/issue-3723from
atavism/issue-3723-payment-screenshot

Conversation

@atavism

@atavism atavism commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Captures the Stripe Checkout WebView directly during the macOS payment smoke test, waits until it contains visible rendered content, and saves the resulting PNG with the test artifacts.

Copilot AI lite review requested due to automatic review settings August 6, 2026 12:49
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d8f11e2-7aea-434d-a87c-62f02d7cdc17

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds first-class Stripe Checkout WebView screenshot capture to the macOS desktop payment smoke test, validating that the Checkout UI is visibly rendered and emitting the PNG as a CI artifact.

Changes:

  • Extend AppWebViewObserver.onPageLoaded to support async observers and provide a captureScreenshot callback.
  • Update the macOS Stripe Checkout integration test to poll until the WebView screenshot shows rendered content, then persist it via a --dart-define path.
  • Simplify the macOS smoke runner script to pass the screenshot output path into the test and assert the artifact was created.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
lib/core/widgets/app_webview.dart Makes page-load observation async and supplies a screenshot capture callback to observers.
integration_test/payment/desktop_stripe_checkout_smoke_test.dart Captures/validates Stripe Checkout WebView screenshots on macOS and writes them to an artifacts path.
.github/scripts/macos_payment_checkout_smoke.sh Passes screenshot output path via --dart-define and checks that the PNG exists.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +191 to +195
await observer.onPageLoaded(
uri,
documentLength: documentLength,
captureScreenshot: () => controller.takeScreenshot(),
);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants