capture and validate Stripe Checkout screenshots - #8956
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds first-class Stripe Checkout WebView screenshot capture to the macOS desktop payment smoke test, validating that the Checkout UI is visibly rendered and emitting the PNG as a CI artifact.
Changes:
- Extend
AppWebViewObserver.onPageLoadedto support async observers and provide acaptureScreenshotcallback. - Update the macOS Stripe Checkout integration test to poll until the WebView screenshot shows rendered content, then persist it via a
--dart-definepath. - Simplify the macOS smoke runner script to pass the screenshot output path into the test and assert the artifact was created.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/core/widgets/app_webview.dart | Makes page-load observation async and supplies a screenshot capture callback to observers. |
| integration_test/payment/desktop_stripe_checkout_smoke_test.dart | Captures/validates Stripe Checkout WebView screenshots on macOS and writes them to an artifacts path. |
| .github/scripts/macos_payment_checkout_smoke.sh | Passes screenshot output path via --dart-define and checks that the PNG exists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| await observer.onPageLoaded( | ||
| uri, | ||
| documentLength: documentLength, | ||
| captureScreenshot: () => controller.takeScreenshot(), | ||
| ); |
…/issue-3723-payment-screenshot
Captures the Stripe Checkout WebView directly during the macOS payment smoke test, waits until it contains visible rendered content, and saves the resulting PNG with the test artifacts.