Skip to content

feat(vss): log user_token (JWT sub) on auth and request log/sentry sites #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bumi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(vss): log user_token (JWT sub) on auth and request log/sentry sites #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions rust/server/src/vss_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ async fn handle_request<
.await
{
Ok(auth_response) => {
tracing::info!("Authentication successful");
tracing::info!(user_token = %auth_response.user_token, "Authentication successful");
auth_response.user_token
},
Err(e) => {
Expand All @@ -329,7 +329,7 @@ async fn handle_request<
Err(_) => {
Span::current().record("http.status_code", 413);
Span::current().record("error", true);
tracing::warn!(http.status_code = 413, "Request body too large");
tracing::warn!(user_token = %user_token, http.status_code = 413, "Request body too large");
return Ok(Response::builder()
.status(StatusCode::PAYLOAD_TOO_LARGE)
.body(Full::new(Bytes::from("Request body too large")))
Expand All @@ -342,12 +342,13 @@ async fn handle_request<
Span::current().record("http.request.body.size", bytes.len());

match T::decode(bytes) {
Ok(request) => match handler(store.clone(), user_token, request).await {
Ok(request) => match handler(store.clone(), user_token.clone(), request).await {
Ok(response) => {
let response_bytes = response.encode_to_vec();
Span::current().record("http.response.body.size", response_bytes.len());
Span::current().record("http.status_code", 200);
tracing::info!(
user_token = %user_token,
http.status_code = 200,
operation = operation_name,
"Request completed successfully"
Expand All @@ -365,35 +366,35 @@ async fn handle_request<
match &e {
VssError::InternalServerError(msg) => {
sentry::capture_message(
&format!("Internal server error: {}", msg),
&format!("Internal server error for user_token {}: {}", user_token, msg),
sentry::Level::Error,
);
tracing::error!(error = %e, http.status_code = status_code, "Internal server error");
tracing::error!(user_token = %user_token, error = %e, http.status_code = status_code, "Internal server error");
},
VssError::NoSuchKeyError(_) => {
// NoSuchKeyError is a normal case when a key doesn't exist (404).
// Don't send these to Sentry as they're expected errors.
tracing::info!(error = %e, http.status_code = status_code, "Key not found");
tracing::info!(user_token = %user_token, error = %e, http.status_code = status_code, "Key not found");
},
_ => {
sentry::capture_message(
&format!("Request error: {}", e),
&format!("Request error for user_token {}: {}", user_token, e),
sentry::Level::Warning,
);
tracing::warn!(error = %e, http.status_code = status_code, "Request error");
tracing::warn!(user_token = %user_token, error = %e, http.status_code = status_code, "Request error");
},
}
Ok(build_error_response(e))
},
},
Err(e) => {
sentry::capture_message(
&format!("Error parsing protobuf request: {}", e),
&format!("Error parsing protobuf request for user_token {}: {}", user_token, e),
sentry::Level::Warning,
);
Span::current().record("http.status_code", 400);
Span::current().record("error", true);
tracing::warn!(error = %e, http.status_code = 400, "Error parsing protobuf request");
tracing::warn!(user_token = %user_token, error = %e, http.status_code = 400, "Error parsing protobuf request");
Ok(Response::builder()
.status(StatusCode::BAD_REQUEST)
.body(Full::new(Bytes::from(b"Error parsing request".to_vec())))
Expand Down
Loading