Skip to content

[Clean Version] Extend PR #3089 – Complete Fiat Input Support in Dual Currency Field#3395

Open
Dunsin-cyber wants to merge 21 commits into
getAlby:masterfrom
Dunsin-cyber:clean-refine-dual-currency
Open

[Clean Version] Extend PR #3089 – Complete Fiat Input Support in Dual Currency Field#3395
Dunsin-cyber wants to merge 21 commits into
getAlby:masterfrom
Dunsin-cyber:clean-refine-dual-currency

Conversation

@Dunsin-cyber

@Dunsin-cyber Dunsin-cyber commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

🚀 Summary

This pull request continues from where #3089 left off and cleans up the messy rebase/force-push in #3394. That initial PR laid the groundwork, and this one builds upon it to complete the implementation and resolve remaining issues.

✨ Changes Introduced

A breakdown of what this PR introduces:

  • Fixed all failing tests, particularly for ConfirmPayment and SitePreferences.
  • ConfirmPayment Fix:
    Added a default mock implementation for getFormattedInCurrency in the SettingsContext. This resolves the failing unit tests in ConfirmPayment/index.test.tsx caused by a missing mock.
  • SitePreferences Fix: rewrites the test to focus more on testing the core functionality, like whether the budget was created, the user's input was reflected correctly, and the conversion worked.

🔗 Related Issues or PRs

🧩 Type of Change

Select the appropriate type:

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat!: Breaking change (may break existing functionality)

📸 Screenshots (optional)

Add any relevant screenshots, screen recordings, or UI diffs to help reviewers.

🧪 How This Was Tested

  • Manual testing
  • Unit/integration tests
  • Test environment notes: [Optional: add environment or tool info if relevant]

✅ Checklist

  • Code reviewed and cleaned up
  • Manual tests run successfully
  • Automated tests added or updated
  • Documentation and guides updated (if applicable)

For UI-related changes:

  • Dark mode tested
  • Responsive layout verified

@Dunsin-cyber

Copy link
Copy Markdown
Contributor Author

hi @pavanjoshi914 , this PR is now ready for review 🚀⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit switching within the "Amount" input

3 participants