Use spatial correlation also in impact jobs - #11695
Draft
ptormene wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, when calculating the gmfs in impact calculations, we have been using the 'basic' (faster) approach without correlation. We need to use 'Silva&Horspool' instead. This will make the computation heavier and slower. Let's see how this will affect the computational performance.
I am also running tests here: https://github.com/gem/oq-engine/actions/runs/31259846195
and here: https://github.com/gem/oq-engine/actions/runs/31259857636
I tried on the staging machine using the impact_report branch plus the spatial correlation, and I got the following error after attempting to run an impact job using the ShakeMap with ID
us6000t7zp:Using the small (sampled) exposure, I completed the same calculation on my laptop, but the full exposure makes the computation too expensive. For now I will roll back the staging machine to work without spatial correlation, then we will need to further discuss about this.