Skip to content

refactor: render the templates with envsubst - #419

Open
fwiesel wants to merge 1 commit into
mainfrom
refactor/integration-envsubst
Open

fwiesel wants to merge 1 commit into
mainfrom
refactor/integration-envsubst

Conversation

@fwiesel

@fwiesel fwiesel commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The integration actions rewrote their tracked templates with sed -i, so a
checkout held placeholders after the first step and a rerun started from a
half-rendered file.

envsubst renders into a new file, names the variables it substitutes, and
: "${SSH_KEY:?...}" guards stop an unset input before a hypervisor sees a
partial template.

In-place sed replacements mutate tracked template files and silently
leave literal placeholders behind when a variable name changes or is
unset. Rendering through envsubst with explicit unset-variable guards
keeps the source templates clean and fails fast when a required value is
missing.

envsubst reads the process environment, not the shell variables of the
calling step, and $GITHUB_ENV reaches only the later steps. Without the
export, the key and the password hash render as empty strings into the
ignition file, and the hypervisor rejects every login until the job
times out.

Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@fwiesel
fwiesel force-pushed the refactor/integration-envsubst branch from 17e0fdc to 01548c8 Compare November 16, 2026 12:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant