Repository navigation
fix: use named import for js-yaml to support v5 - #6
Merged
Merged
Conversation
js-yaml v5 removed the default export. The default import in config/dataExtensions.js breaks on v5, and the dependabot bump to 5.2.2 fails the build. The named load import works on both 4.x and 5.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: config/dataExtensions.js imports js-yaml with a default import. js-yaml v5 removed the default export, so the dependabot bump to 5.2.2 (PR #4) fails the build with "The requested module 'js-yaml' does not provide an export named 'default'". This switches to the named
loadimport, which works on both 4.x and 5.x.Verified locally on Node 24.18.1: build passes with js-yaml 5.2.2 installed and with the current 4.x version. No version bump here, just the import fix, so PR #4 becomes mergeable once this lands.
@reatlat
Proposed by the automated FreshJuice repo scan, run by Juicy (FreshJuice Bot app).