Repository navigation
Return NaN when a rolling window is longer than the series - #846
Merged
xmatthias merged 2 commits intoOct 27, 2026
Merged
Conversation
xmatthias
requested changes
Oct 26, 2026
xmatthias
left a comment
xmatthias
left a comment
Member
There was a problem hiding this comment.
ci fails ... which is a requirement for obvious reasons.
Your tests are also kindof lacking some quite likely edge-cases - you'll want a test for len==window (essentially the "off by 1" regression test).
Ruff PLR1730 rejected the negative-count branch, which also failed the distribution build. Clamp the window count with max, import the public qtpylib helpers in tests, and lock the len == window off-by-one case. Co-authored-by: xvruipeng-cyber <xvruipeng-cyber@users.noreply.github.com>
xmatthias
enabled auto-merge
October 27, 2026 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #464
numpy_rolling_windowbuilt a negative shape when the input was shorter thanwindow, so indicators such as the awesome oscillator crashed instead of warming up. Upstream qtpylib is archived, and this copy is now the onetechnical.qtpylibexports.A short series now produces an empty window. The rolling reducer leaves the result as NaN, including the
len(calculated) == 0case whereseries[-0:]would otherwise replace the whole array. A complete window is unchanged.Test plan
pytest tests/test_rolling_window.py(4 passed)Made with Cursor