Repository navigation
parker5: Batman V throughput, failover and DHCP fixes - #1006
Merged
Merged
Conversation
Parker nodes sent a pseudo TQ for Batman V neighbours. The map showed TQ 100% for most links and no throughput. Add a patch that sends the raw throughput in kbit/s. yanic with Batman V support then writes source_tp and target_tp. Port of the upstream change by Grische (freifunk-gluon/gluon#3736) to the gluon-parker Batman V patch series.
Update ffbs-mesh-vpn-parker: - report the pgw address as respondd gateway - make dnsmasq not authoritative - send router lifetime 0 only after a new router - no router lifetime 0 when a site of the node is up again - a router with deprecated prefixes only is not a new router - stop the parker uradvd when no site is active - quote the message in util.log
7a2a037 is not on parker-release-2026.11 as a branch point, so gluon-prepare fails. Pin the merge commit 70dba2e. It has the same tree as 7a2a037.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes parker5. It updates community-packages to the parker5 stack and adds one Gluon patch for Batman V. The fixes are for the map, for DHCP after a site switch, and for the router advertisements (RA) during a site failover.
Commits:
patches/0026: Batman V. The node sends the link throughput to respondd.modules: community-packages76b4411→70dba2e(merge commit of the stack; same tree as7a2a037).Community-packages stack (bottom to top):
84ff6d7)3612f60)74b26b6,c899339,fb3b50a,3925bed)7a2a037)1. respondd gateway (#55)
gatewayfield. yanic cannot find a node with this ID.gateway6. yanic maps this address to the pgw node. If the pgw has no IPv6 address, the node uses the old text.2. dnsmasq is not authoritative (#56)
PARKER_DHCP). The client then sends a rebind as a broadcast. An authoritative dnsmasq answered with a DHCPACK for the same address, but with a different router address. Android 11 then failed to change its IPv4 default route ("File exists").3. RA goodbye race (#57)
74b26b6): The node stops its RA daemons and startsparker-ra-goodbye. The script waits until a new router is onbr-client. After 2 s more, it sends router lifetime 0 for 8 s. If no new router comes in 180 s, it sends nothing. The router lifetime on the clients then ends by itself.The lab found three more faults in this logic. These commits fix them:
c899339: All uplink nodes can come back at the same time. Then the router of another node can come first, and the node sent router lifetime 0 for its own prefixes. Now the node sends nothing when a site of the node is up again.fb3b50a: An uplink node with no tunnels still sends RAs, but only with deprecated prefixes. When all uplink nodes were down, the script took such a node as the new router. Now a new router must have a preferred prefix of another node.3925bed: parker-sites could start the parker uradvd again on an inactive node. That node then sent router lifetime 180 and a preferred prefix for the full outage. Now parker-sites stops the parker uradvd when no site is active.4. util.log quoting (#58)
util.loggave the message to the shell without quotes. A "(" in the message caused a shell syntax error.util.logquotes the message.5. Batman V throughput (patches/0026)
throughputfield and no pseudo TQ. yanic with Batman V support writessource_tpandtarget_tptomeshviewer.json. The status page does not change. This is a port of add Batman V support freifunk-gluon/gluon#3736 to the gluon-parker tree. Thank you to @grische for the upstream change.Map frontend: map-parker uses meshviewer v14.0.0. This version does not show
source_tp. To show the throughput, map-parker needs a meshviewer build with Batman V support (freifunk/meshviewer#345). This PR does not change the map.Tests
Lab: 6 nodes (2 uplink nodes, 4 mesh nodes), 2 pgw sites, 12 clients (Alpine, Debian 12 and 13, Android 9, 11 and 15). Image
v2026.11.1-parker4+siteb9af1b7+cp7a2a037-lab-extraon all 6 nodes. It contains the commits of this PR. No hot patches. Test B ran on the earlier parker5 image (withoutc899339,fb3b50a,3925bed,7a2a037and the Batman V patch).gateway=gateway6in 48 of 48 polls during a site cut. The value follows the active pgw (pgw01 → pgw02 → pgw04 → pgw02).authoritative= 0. No duplicate ARP. IPv4 comes back with no manual step, but only at the lease end (81 s). See limits.parker-ra-goodbyeprocess and no stray firewall rule after the tests.batctl ra: BATMAN_V on all nodes. Each respondd neighbour hasthroughputand notq. The status page showstp.Also:
tests/ra-goodbye-test.shin community-packages: 20 PASS.scripts/apply_patches.sh: all patches apply on gluon-parker029ea60.respondd-neighbours.ccompiles withgcc -Wall -Wextraand gives no warnings.Known client limits (no node fix):
Not tested: